coverage: allow to run coverage on _test.go files in subdirs #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pborzenkov Thanks for the fix. Much appreciated. Unfortunately I couldn't understand your exact workflow and what this fixes. Can you please provide a step to step example I can try myself to see what the problem is? |
|
@fatih Whenever I open test file that is not located in current dir :GoCoverage doesn't work. For example, vim path/to/some/file_test.go |
fatih
reviewed
Nov 23, 2016
| @@ -221,6 +221,8 @@ function! go#coverage#overlay(file) | |||
| exe ":edit ". fnamemodify(fname, ":p") | |||
| endif | |||
|
|
|||
| let fname = fnamemodify(fname, ":t") | |||
There was a problem hiding this comment.
Can you add a comment here why you take the trail of the file (for example because of cov.file ...)
|
@pborzenkov this looks good. Sorry for late review, I was abroad and was very busy. |
Due to usage of ':t' modifier to extract filename when switching from file_test.go to file.go, the original path to file is lost and Vim can't open it if it's stored in some subdir. It only worked by accident if the file was located in the same directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to usage of ':t' modifier to extract filename when switching from
file_test.go to file.go, the original path to file is lost and Vim can't
open it if it's stored in some subdir. It only worked by accident if the
file was located in the same directory.