Provide a descriptive quickfix/location list title. #1004
Conversation
|
Can you show an after/before screenshot? For example I've introduced a syntx error, but :GoFmt was not able to parse it and it errored. And a :GoBuild just displayed a normal quickfix list without any name. |
|
It depends on if you are using
but GoFmt would display: because the location list was set explicitly with |
|
@datanoise This is something I want to merge definitely. I have some tasks on the vim-8.0 branch, I'll take another stab once I've merged it to master. Thanks for the work. I'll merge it if there is no problem or try to give a feedback if needed any. |
|
@datanoise can you please rebase against master if possible? |
|
Yes. Working on it. |
| @@ -106,7 +106,7 @@ function! s:guru_cmd(args) range abort | |||
| endfunction | |||
|
|
|||
| " sync_guru runs guru in sync mode with the given arguments | |||
| function! s:sync_guru(args) abort | |||
| function! s:sync_guru(args, title) abort | |||
There was a problem hiding this comment.
title should be a part of args. If you check args you'll see that I'm just passing a single dict because otherwise the number of arguments ot this functions increase over time. I think you even don't need title here, just use a:args.mode which already contains the mode and is the same as title.
There was a problem hiding this comment.
ah, good point. I'll fix it.
| @@ -235,7 +235,7 @@ function! go#guru#Implements(selected) abort | |||
| \ 'needs_scope': 1, | |||
| \ } | |||
|
|
|||
| call s:run_guru(args) | |||
| call s:run_guru(args, 'Implements') | |||
There was a problem hiding this comment.
all run_guru functions should be fixed as well.
There was a problem hiding this comment.
right. I pushed too early. it should be fixed now.
|
Just tested it locally, but it doesn't work for me. This is what I got for
Can you please search for |
|
it should be fixed now. |
|
I've pulled the changes and tried However I don't see
|
|
I'll check it later today. I suspect that there are still cases where I didn't propagate the title. |
Currently, the w:quickfix_title is being automatically set to the actual Vim command that populates quickfix/location list. For example, running any Guru command it will be displayed as ': lgetexpr a:items' which is not really informative.
|
Thanks @datanoise 👍 |
Currently, the
w:quickfix_titleis being automatically set to the actualVim command that populates quickfix/location list. For example, running
any Guru command it will be displayed as
: lgetexpr a:itemswhichis not really informative.