Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enhanced support for geographic coordinates #181
Add enhanced support for geographic coordinates #181
Changes from 48 commits
9f9262b
81530a2
94a5e8e
db1e816
a43b415
836fef2
eea0d9b
457f192
11f691f
aa2ce52
123607e
ed9410f
bdbc6dc
49d96cd
0fc747f
5fb3c0e
88dab93
d0b83e5
2327294
7ad90e9
4855882
d3b86b2
7493f1d
7e527e9
9b1021d
0c3a067
76fc0b9
b6dfa90
98cf7fc
00fddb2
7c5b9c3
5b90b51
75077c9
25de366
956b083
f7ad34d
4f8c502
1c1a92d
157ce34
9dc288a
3c45a6c
9906366
130c96e
614b9e2
3ac3773
5235234
55e58b7
e2e4b7b
fdd1748
7296f84
3e1f495
ca1f440
d822d50
9f3fd5f
a16b01c
4108c6b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be problematic since the region might be very close but not exactly 360. Might lead to slightly off coordinates that could give errors down the line. Is there any way to avoid this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this
all_globe
check in case you passw, e = 0, 360
as region boundaries.If we omit the
all_globe
, the algorithm will returnw, e = 0, 0
, which is problematic.The slightly off coordinates you mention will be within an error of 1e-5 (according to
numpy.allclose
).One simple hack would be to lower down this error, but I don't know if it's ideal.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking for this is "do we need to do this check?". If this is not necessary, then we could skip the check and avoid the issues with precision.