Rails 7 #1196
Merged
Rails 7 #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey I approved CI builds for this PR. Please fix the testing and I'd be happy to approve. Thanks for the help! |
|
ok. Fixed. That was something peculiar with the way sqlite3 adapter was handling the id: :serial. It didn't produce the proper autoincrement field on SQLite. |
|
Good to go? |
|
Thanks! I think this is pretty much good to go with the green build. I will have to think slightly about the fork of responds_to_parent - I'd done my own as a quick and dirty fix; and it's a bit unmaintained. Might merge your fork + my fork together, make a feature branch, stick in the fat free crm organisation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's another take on upgrade to Rails 7. I tried my best to merge the configuration by hand while preserving the copyrights and custom configuration. I believe that as soon as acts_as_commentable supports Rails 7.1, fat_free_crm will support it as well. All tests passed locally.
Fixes #1134