-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies to use Rails 7.1 as the current Rails version #311
Conversation
Without this change, rspec was failing with this: ``` 4) ReportsController#show using HTML response format shows the attributes for the right project Failure/Error: raise TypeError, "#{path.inspect} is not a valid path: must be a String, Pathname, or Resolver" TypeError: #<RSpec::Rails::ViewRendering::EmptyTemplateResolver::ResolverDecorator:0x0000000113c167e0 @resolver=#<ActionView::FileSystemResolver:0x0000000109e1bb80 @unbound_templates=#<Concurrent::Map:0x0000000109e1bb58 entries=41 default_proc=nil>, @path_parser=#<ActionView::Resolver::PathParser:0x0000000110133308 @regex=/ \A (?:(?<prefix>.*)\/)? (?<partial>_)? (?<action>.*?) (?:\.(?<locale>(?-mix:ar|bg|ca\-CAT|ca|da\-DK|de\-AT|de\-CH|de|ee|en|en\-AU|en\-BORK|en\-CA|en\-GB|en\-IND|en\-MS|en\-NEP|en\-NG|en\-NZ|en\-PAK|en\-SG|en\-TH|en\-UG|en\-US|en\-ZA|en\-au\-ocker|es\-AR|es\-MX|es|fa|fi\-FI|fr|fr\-CA|fr\-CH|he|hy|id|it|ja|ko|lt|lv|mi\-NZ|nb\-NO|nl|no\-NO|pl|pt\-BR|pt|ru|sk|sv|th|tr|uk|vi|zh\-CN|zh\-TW|(?-mix:[a-z]{2}(?:[-_][A-Z]{2})?))))?? (?:\.(?<format>(?-mix:html|text|js|css|ics|csv|vcf|vtt|png|jpeg|gif|bmp|tiff|svg|webp|mpeg|mp3|ogg|m4a|webm|mp4|otf|ttf|woff|woff2|xml|rss|atom|yaml|multipart_form|url_encoded_form|json|pdf|zip|gzip)))?? (?:\+(?<variant>[^.]*))?? (?:\.(?<handler>(?-mix:raw|erb|html|builder|ruby|jbuilder)))? \z /x>, @path="/Users/etagwerker/Projects/fastruby/points/app/views">> is not a valid path: must be a String, Pathname, or Resolver # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionview-7.1.0/lib/action_view/path_set.rb:79:in `block in typecast' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionview-7.1.0/lib/action_view/path_set.rb:68:in `map' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionview-7.1.0/lib/action_view/path_set.rb:68:in `typecast' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionview-7.1.0/lib/action_view/path_set.rb:19:in `initialize' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionview-7.1.0/lib/action_view/view_paths.rb:35:in `new' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionview-7.1.0/lib/action_view/view_paths.rb:35:in `_build_view_paths' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/actionview-7.1.0/lib/action_view/view_paths.rb:69:in `view_paths=' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-rails-4.0.2/lib/rspec/rails/view_rendering.rb:153:in `block (2 levels) in <module:ViewRendering>' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:457:in `instance_exec' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:457:in `instance_exec' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:365:in `run' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:529:in `block in run_owned_hooks_for' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:528:in `each' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:528:in `run_owned_hooks_for' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:615:in `block in run_example_hooks_for' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:614:in `reverse_each' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:614:in `run_example_hooks_for' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:484:in `run' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:505:in `run_before_example' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:261:in `block in run' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:511:in `block in with_around_and_singleton_context_hooks' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:468:in `block in with_around_example_hooks' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:486:in `block in run' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:626:in `block in run_around_example_hooks_for' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:352:in `call' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-rails-4.0.2/lib/rspec/rails/example/controller_example_group.rb:191:in `block (2 levels) in <module:ControllerExampleGroup>' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:457:in `instance_exec' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:457:in `instance_exec' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:390:in `execute_with' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:628:in `block (2 levels) in run_around_example_hooks_for' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:352:in `call' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-rails-4.0.2/lib/rspec/rails/adapters.rb:75:in `block (2 levels) in <module:MinitestLifecycleAdapter>' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:457:in `instance_exec' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:457:in `instance_exec' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:390:in `execute_with' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:628:in `block (2 levels) in run_around_example_hooks_for' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:352:in `call' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:629:in `run_around_example_hooks_for' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/hooks.rb:486:in `run' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:468:in `with_around_example_hooks' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:511:in `with_around_and_singleton_context_hooks' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example.rb:259:in `run' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example_group.rb:646:in `block in run_examples' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example_group.rb:642:in `map' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example_group.rb:642:in `run_examples' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example_group.rb:607:in `run' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example_group.rb:608:in `block in run' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example_group.rb:608:in `map' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example_group.rb:608:in `run' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example_group.rb:608:in `block in run' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example_group.rb:608:in `map' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/example_group.rb:608:in `run' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/runner.rb:121:in `block (3 levels) in run_specs' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/runner.rb:121:in `map' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/runner.rb:121:in `block (2 levels) in run_specs' # /Users/etagwerker/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.12.2/lib/rspec/core/configuration.rb:2070:in `with_suite_hooks' Add `render_views` to reports_controller ```
ca4d7dd
to
7ffad28
Compare
`bundle lock --add-platform x86_64-linux`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 !
@etagwerker QA'ed locally it works as expected but the review app failed here is the trace
|
@etagwerker without uglifier we don't have assets minification (well I guess we do have JS minification because of webpacker maybe? but we won't have for the CSS) uglifier is rather old though, maybe what we need to do is to replace that with yui-compressor https://guides.rubyonrails.org/asset_pipeline.html#customizing-the-pipeline |
@etagwerker @arielj, yui-compressor is also failing with this message It seems like it requires Java |
Jira Ticket
ROAD-556
Motivation / Context
We want to use the latest Rails version
QA / Testing Instructions
Application should just work as expected with Rails 7.1
I will abide by the code of conduct.