Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 wheel build support #246

Merged
merged 1 commit into from
Sep 19, 2021
Merged

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Aug 17, 2021

Added aarch64 wheel build support.
Related to #245, @althonos Could you please review this PR?

@althonos
Copy link
Member

@odidev : I allowed you to run the GH actions, you should be able to test your changes now.

@odidev
Copy link
Contributor Author

odidev commented Aug 18, 2021

I’m facing the following Assertion Error on running tests.

FAIL: load_graph (fastobo) 
Doctest: fastobo.load_graph 
---------------------------------------------------------------------- 
Traceback (most recent call last): 
  File "/opt/python/cp37-cp37m/lib/python3.7/doctest.py", line 2204, in runTest 
    raise self.failureException(self.format_failure(new.getvalue())) 
AssertionError: Failed doctest test for fastobo.load_graph 
  File "/ws/fastobo.cpython-37m-aarch64-linux-gnu.so", line unknown line number, in load_graph 

---------------------------------------------------------------------- 
File "/ws/fastobo.cpython-37m-aarch64-linux-gnu.so", line ?, in fastobo.load_graph 
Failed example: 
    doc[0] 
Expected:
    TermFrame(PrefixedIdent('BFO', '0000002')) 
Got: 
    TermFrame(PrefixedIdent('BFO', '0000001')) 

---------------------------------------------------------------------- 

Ran 125 tests in 10.934s

FAILED (failures=1, expected failures=3)

Also this error is seen in x86. Is it an expected error? Could you please have a look?

@althonos
Copy link
Member

@odidev : this was an issue with one of the doctests failing, I have pushed a fix to the main branch, you can pull from that and it should fix it.

Signed-off-by: odidev <odidev@puresoftware.com>
@odidev
Copy link
Contributor Author

odidev commented Aug 31, 2021

Done.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #246 (755bc19) into master (a01bdf0) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   34.69%   34.71%   +0.02%     
==========================================
  Files          24       24              
  Lines        3678     3678              
==========================================
+ Hits         1276     1277       +1     
+ Misses       2402     2401       -1     
Impacted Files Coverage Δ
src/py/mod.rs 76.00% <0.00%> (-2.00%) ⬇️
src/py/id.rs 59.48% <0.00%> (-0.52%) ⬇️
src/py/term/clause.rs 27.80% <0.00%> (-0.17%) ⬇️
src/py/typedef/clause.rs 11.95% <0.00%> (-0.10%) ⬇️
src/py/pv.rs 69.91% <0.00%> (+0.81%) ⬆️
src/py/doc.rs 78.66% <0.00%> (+1.33%) ⬆️
src/error.rs 50.00% <0.00%> (+1.47%) ⬆️
src/iter.rs 58.16% <0.00%> (+3.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01bdf0...755bc19. Read the comment docs.

@althonos althonos merged commit 13d686a into fastobo:master Sep 19, 2021
@althonos
Copy link
Member

Thanks a bunch! I'll be making a new postrelease to get the wheels on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants