Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete parameter mapping between pytorch and keras #847

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

JanFSchulte
Copy link
Contributor

@JanFSchulte JanFSchulte commented Aug 10, 2023

The pytorch parser still uses a mapping between tensor names from keras to pytorch which has become obsolete. In its current form, it breaks BatchNorm layers. This PR simply removes this functionality, restoring BatchNorm functionality and removing clutter. A test for BatchNorm in pytorch is added to prevent further breaking of this functionality

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change that fixes an issue)

Tests

Ran pytests to verify that nothing gets broken, verified that BatchNorm layers parse successfully after the fix.

Checklist

  • I have read the guidelines for contributing.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@JanFSchulte JanFSchulte changed the title Rmove obsolete parameter mapping between pytorch and keras Remove obsolete parameter mapping between pytorch and keras Aug 10, 2023
@jmitrevs jmitrevs added the please test Trigger testing by creating local PR branch label Aug 10, 2023
@jmitrevs jmitrevs self-assigned this Aug 10, 2023
@jmitrevs jmitrevs merged commit 490ac46 into fastmachinelearning:main Aug 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants