Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue and PR templates #582

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Add issue and PR templates #582

merged 3 commits into from
Jun 23, 2022

Conversation

jmduarte
Copy link
Member

Add issue and PR templates

Closes #581

@jmduarte jmduarte self-assigned this Jun 22, 2022
@jmduarte jmduarte requested a review from vloncar June 22, 2022 16:33
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
## Checklist

- [ ] I have read the [guidelines for contributing](https://github.com/fastmachinelearning/hls4ml/blob/master/CONTRIBUTING.md).
- [ ] I have commented my code, particularly in hard-to-understand areas.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection 👌
This should also be asked in the bug reporting code

Copy link
Member Author

@jmduarte jmduarte Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i added what you requested, but double-check!

Add what needs to be done to reproduce the bug. Add *commented* code examples and make sure to include the original model files / code, and the commit hash you are working on.

@jmduarte jmduarte requested a review from vloncar June 23, 2022 03:55
Copy link
Contributor

@vloncar vloncar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vloncar vloncar merged commit d6d0c19 into master Jun 23, 2022
@vloncar vloncar deleted the issue_pr_template branch June 23, 2022 12:40
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
* issue and PR templates

* typo

* respond to vlad comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add issue template and PR template
2 participants