Remove the in/out size from top function #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmduarte
approved these changes
Jun 17, 2022
calad0i
pushed a commit
to calad0i/hls4ml
that referenced
this pull request
Jul 1, 2023
Remove the in/out size from top function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of input and output that is part of the top function is never used and can be removed. Since the data type used is
shortlarge models emit warnings. #543 suggested a fix, but after some thought, we should get rid of this feature altogether.Basically, instead of
myproject(input_t input_1, result_t result, unsigned short &const_size_in_1, unsigned short &const_size_out_1), we domyproject(input_t input_1, result_t result).