Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log placement support #96

Closed
wants to merge 3 commits into from

Conversation

josehelps
Copy link

@josehelps josehelps commented Sep 26, 2018

The Fastly WAF uses the placement functionality to determine if the logging endpoint is a WAF logging endpoint or not. A WAF logging endpoint is unique in the fact that has unique fields like waf.logdata and waf.rule available to log for one or many WAF event in a single request.

You can find out more information how placement is used for WAF at: https://docs.fastly.com/guides/web-application-firewall/fastly-waf-logging#waf_debug_log

I am not 100% sure if I should update testing for other endpoints, please advice. Also updated the go-fastly library to have the underlying calls for the logging integration also understand placement. Some already supported it but not all, see: fastly/go-fastly#88 for details. Thank you

@ghost ghost added size/S size/M and removed size/S labels Sep 26, 2018
@ghost ghost added the size/M label Sep 26, 2018
@lanej
Copy link
Contributor

lanej commented Sep 26, 2018

@d1vious The error should be more obvious now. Placement support in go-fastly needs to be added in other logging providers AND the create/update logging input structs.

@josehelps
Copy link
Author

@lanej it does thank you, just created a pull to correct these at fastly/go-fastly#89

@philippschulte
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants