A few small tweaks to make consistent with the rest of the API #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make Snippet "Type" a type (like Headers, Cache and Request settings) * SnippetName -> Name * SnippetID -> ID Also use some of the generic error types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, more breaking changes for VCL Snippets... :(
Typeits own type vs a string (like Headers, Cache and Request settings)SnippetName->NameSnippetID->ID(like ACL's, though the underlying Fastly API issnippet_idfor Dynamic Snippets)Also use some of the pre-existing, generic error types rather than creating ones specific to Snippets.