breaking(product_enablement): Remove support for NGWAF product. #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enablement of NGWAF was added recently but never worked, because enablement of the product requires configuration information to be included and that was overlooked. Product configuration will be a significant addition. While this is technically a breaking change, since it never worked, and was only used by the Fastly CLI and the Fastly Terraform provider (both of which will also have NGWAF product enablement removed), there is no need for a major version number increase. Support for this product will be re-added in a future version where 'product configuration' is also added.
kpfleming
force-pushed
the
remove-ngwaf-product-enablement
branch
from
5a8c019 to
0d71658
Compare
Integralist
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enablement of NGWAF was added recently but never worked, because enablement of the product requires configuration information to be included and that was overlooked. Product configuration will be a significant addition.
While this is technically a breaking change, since it never worked, and was only used by the Fastly CLI and the Fastly Terraform provider (both of which will also have NGWAF product enablement removed), there is no need for a major version number increase.
Support for this product will be re-added in a future version where 'product configuration' is also added.