feat(custom_dashboards): Add support for Custom Dashboards APIs. #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlindsay
force-pushed
the
pl/custom-dashboards
branch
from
05304a7 to
13c5804
Compare
tlindsay
force-pushed
the
pl/custom-dashboards
branch
from
61c01aa to
5f00e27
Compare
tlindsay
force-pushed
the
pl/custom-dashboards
branch
from
9e58597 to
a5d0b52
Compare
tlindsay
force-pushed
the
pl/custom-dashboards
branch
from
a5d0b52 to
5f8f4f8
Compare
tlindsay
commented
Sep 25, 2024
| Visualization DashboardVisualization `json:"visualization"` | ||
| } | ||
|
|
||
| type DashboardSourceType string |
There was a problem hiding this comment.
Naming types/constants is really hard. I'm not sure how to balance user-ergonomics with collision-avoidance since all of our API wrappers live in the same package/namespace.
Advice/input is welcomed!
There was a problem hiding this comment.
If you have generally acyclic type dependencies, it's a common pattern to split types/functions into a sub-package, eg .../dashboard which acts as a namespace.
The caller side looks like dashboard.Observability, dashboard.Type, dashboard.Options etc.
There was a problem hiding this comment.
Go type aliases can be used to migrate gradually without breaking backwards compatibility.
kpfleming
changed the title
kpfleming
requested changes
Sep 25, 2024
kpfleming
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DI-1346 Implements client for Observability Custom Dashboards API