Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure that service IDs provided to API operations are alphanumeric. #543

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix: Ensure that service IDs provided to API operations are alphanumeric. #543

merged 2 commits into from
Sep 5, 2024

Conversation

domcyrus
Copy link
Contributor

Validates service id to be alphanumeric in all places where it is used.

Addresses #541

@domcyrus domcyrus mentioned this pull request Sep 5, 2024
Closed
@kpfleming
Copy link
Contributor

I was debating about suggesting use of unicode instead of hard-coded comparisons, but I see that you already considered that and made the correct choice (only ASCII letters and digits should be accepted, not all Unicode letters and digits).

@kpfleming kpfleming changed the title feat: validate service id to be alphanumeric fix: Ensure that service IDs provided to API operations are alphanumeric. Sep 5, 2024
@kpfleming kpfleming merged commit 5245c1a into fastly:main Sep 5, 2024
2 checks passed
@kpfleming kpfleming mentioned this pull request Sep 6, 2024
Merged
kpfleming added a commit that referenced this pull request Sep 7, 2024
@kpfleming
Revert "fix: Ensure that service IDs provided to API operations are a…
a8b8f26 
…lphanumeric. (#543)"

This reverts commit 5245c1a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domcyrus @kpfleming