Add TCP Keep-Alive parameters to backend structs #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
reviewed
Aug 6, 2024
fastly/backend.go
Outdated
Comment on lines
41
to
44
| TcpKeepAliveEnable *bool `mapstructure:"tcp_keepalive_enable"` | ||
| TcpKeepAliveIntvl *int `mapstructure:"tcp_keepalive_interval"` | ||
| TcpKeepAliveProbes *int `mapstructure:"tcp_keepalive_probes"` | ||
| TcpKeepAliveTime *int `mapstructure:"tcp_keepalive_time"` |
There was a problem hiding this comment.
I've always used https://github.com/mgechev/revive for linting go-fastly for linting Fastly's Go projects, and there is the following rule that will trigger a warning...
https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#var-naming
This applies to all references of Tcp.
Integralist
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the TCP keep-alive fields that the Fastly API currently accepts to the different backend structs. They won't work with Compute at the moment, but I believe they should be usable with Delivery.