Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package): add ClonedFrom field to PackageMetadata #527

Merged
merged 4 commits into from
May 28, 2024

Conversation

jsocol
Copy link
Member

@jsocol jsocol commented May 20, 2024

We recently exposed the source repo for e.g. Compute Starter Kits via
the cloned_from key in the PackageMetadata resource in the API. This
makes it programmatically accessible.

We recently exposed the source repo for e.g. Compute Starter Kits via
the `cloned_from` key in the PackageMetadata resource in the API. This
makes it programmatically accessible.
@jsocol jsocol requested a review from Integralist May 20, 2024 18:22
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, otherwise LGTM.

fastly/compute_package.go Outdated Show resolved Hide resolved
@Integralist Integralist added the enhancement New feature or request label May 21, 2024
* Sort struct fields
* Run `make fix-fixtures FASTLY_TEST_SERVICE_ID=sSsCewrlNQiMzZHiqD8Xr0`
This updates the valid.tar.gz package to the current Rust empty Starter
Kit and updates fixtures to match by following the steps in TESTING.md.
@jsocol jsocol requested a review from Integralist May 24, 2024 20:31
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this from the newest Rust empty Starter Kit, so it got a little smaller (yay) and added the cloned_from metadata

@Integralist Integralist changed the title Add ClonedFrom to PackageMetadata feat(package): add ClonedFrom field to PackageMetadata May 28, 2024
@Integralist Integralist merged commit 9804362 into main May 28, 2024
4 checks passed
@Integralist Integralist deleted the jsocol/expose-package-cloned-from-metadata branch May 28, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants