Additions to Service, Domain, and Backend #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Service now supports `deleted_at`; added deleted, created, updated at - Updates documentation on domain; it's for the Service, not account - Added Hostname to backend; if a hostname is used in address, it will show up here. If an IP is used, hostname will be empty
|
Hey @catsby, They are hardcoded to an account. I'm going to try to setup something like VCR to record and commit the responses soonish |
|
Thanks Seth! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleted_at; added deleted, created, updated athere. If an IP is used, hostname will be empty
I had difficulty running tests... it seems they are hardcoded to an account?
I took a spike at refactoring that, but I don't know a way to clean up a service after each test/suite