Replace most helpers with a generic ToPointer function #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
approved these changes
Nov 17, 2023
joeshaw
reviewed
Nov 17, 2023
| // Bool is a helper that returns a pointer to the bool value passed in. | ||
| func Bool(v bool) *bool { | ||
| // ToPointer converts T to *T. | ||
| func ToPointer[T string | int | uint | uint8 | bool | CacheSettingAction | Compatibool | ERLAction | ERLLogger | ERLWindowSize | RequestSettingAction | RequestSettingXFF | S3AccessControlList | S3Redundancy | S3ServerSideEncryption](v T) *T { |
There was a problem hiding this comment.
Curious why you specify all these types rather than using any?
I wonder also if you could use the ~ sigil on the primitive types to get the underlying types? If not any then ~string | ~int | ~uint | ~uint8 | ~bool?
There was a problem hiding this comment.
Haha never mind, I just saw the follow-up PR. (#490)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed with @Integralist .