breaking(object-store): rename ObjectStore to KVStore #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
changed the title
Integralist
changed the title
Integralist
changed the title
Integralist
changed the title
Integralist
requested changes
Apr 12, 2023
There was a problem hiding this comment.
Looks like we've made a change that shouldn't have been made...
fastly/response_object.go → fastly/response_kv.go
That file (and its associated test) is not related to the Object Store but to a VCL 'response object': https://developer.fastly.com/reference/api/vcl-services/response-object/
Integralist
reviewed
Apr 12, 2023
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are renaming object store to kv store so doing the needed changes here.
This needs an internal API change and when that is out it should start working on a test rerun.