Ensure relevant logging endpoints have their token marked as required

fastly/datadog.go

@@ -94,6 +94,10 @@ func (c *Client) CreateDatadog(i *CreateDatadogInput) (*Datadog, error) {
 		return nil, ErrMissingServiceVersion
 	}
 
+	if i.Token == "" {
+		return nil, ErrMissingToken
+	}
+
 	path := fmt.Sprintf("/service/%s/version/%d/logging/datadog", i.ServiceID, i.ServiceVersion)
 	resp, err := c.PostForm(path, i, nil)
 	if err != nil {
@@ -180,6 +184,10 @@ func (c *Client) UpdateDatadog(i *UpdateDatadogInput) (*Datadog, error) {
 		return nil, ErrMissingName
 	}
 
+	if i.Token != nil && *i.Token == "" {
+		return nil, ErrTokenEmpty
+	}
+
 	path := fmt.Sprintf("/service/%s/version/%d/logging/datadog/%s", i.ServiceID, i.ServiceVersion, url.PathEscape(i.Name))
 	resp, err := c.PutForm(path, i, nil)
 	if err != nil {

fastly/errors.go

@@ -45,6 +45,12 @@ func NewFieldError(kind string) *FieldError {
 	}
 }
 
+const emptyTokenInvalid string = "the token value cannot be empty"
+
+// ErrTokenEmpty is an error that is returned when an input struct
+// specifies an "Token" key value which the user has set to an empty string.
+var ErrTokenEmpty = NewFieldError("Token").Message(emptyTokenInvalid)
+
 const batchModifyMaxExceeded string = "batch modify maximum operations exceeded"
 
 // ErrMaxExceededEntries is an error that is returned when an input struct
@@ -269,6 +275,10 @@ var ErrNotImplemented = errors.New("not implemented")
 // already enabled for a service.
 var ErrManagedLoggingEnabled = errors.New("managed logging already enabled")
 
+// ErrMissingToken is an error that is returned when an input struct
+// requires a "Token" key, but one was not set.
+var ErrMissingToken = NewFieldError("Token")
+
 // Ensure HTTPError is, in fact, an error.
 var _ error = (*HTTPError)(nil)
 

fastly/honeycomb.go

@@ -94,6 +94,10 @@ func (c *Client) CreateHoneycomb(i *CreateHoneycombInput) (*Honeycomb, error) {
 		return nil, ErrMissingServiceVersion
 	}
 
+	if i.Token == "" {
+		return nil, ErrMissingToken
+	}
+
 	path := fmt.Sprintf("/service/%s/version/%d/logging/honeycomb", i.ServiceID, i.ServiceVersion)
 	resp, err := c.PostForm(path, i, nil)
 	if err != nil {
@@ -180,6 +184,10 @@ func (c *Client) UpdateHoneycomb(i *UpdateHoneycombInput) (*Honeycomb, error) {
 		return nil, ErrMissingName
 	}
 
+	if i.Token != nil && *i.Token == "" {
+		return nil, ErrTokenEmpty
+	}
+
 	path := fmt.Sprintf("/service/%s/version/%d/logging/honeycomb/%s", i.ServiceID, i.ServiceVersion, url.PathEscape(i.Name))
 	resp, err := c.PutForm(path, i, nil)
 	if err != nil {

fastly/newrelic.go

@@ -94,6 +94,10 @@ func (c *Client) CreateNewRelic(i *CreateNewRelicInput) (*NewRelic, error) {
 		return nil, ErrMissingServiceVersion
 	}
 
+	if i.Token == "" {
+		return nil, ErrMissingToken
+	}
+
 	path := fmt.Sprintf("/service/%s/version/%d/logging/newrelic", i.ServiceID, i.ServiceVersion)
 	resp, err := c.PostForm(path, i, nil)
 	if err != nil {
@@ -180,6 +184,10 @@ func (c *Client) UpdateNewRelic(i *UpdateNewRelicInput) (*NewRelic, error) {
 		return nil, ErrMissingName
 	}
 
+	if i.Token != nil && *i.Token == "" {
+		return nil, ErrTokenEmpty
+	}
+
 	path := fmt.Sprintf("/service/%s/version/%d/logging/newrelic/%s", i.ServiceID, i.ServiceVersion, url.PathEscape(i.Name))
 	resp, err := c.PutForm(path, i, nil)
 	if err != nil {

fastly/scalyr.go

@@ -94,6 +94,10 @@ func (c *Client) CreateScalyr(i *CreateScalyrInput) (*Scalyr, error) {
 		return nil, ErrMissingServiceVersion
 	}
 
+	if i.Token == "" {
+		return nil, ErrMissingToken
+	}
+
 	path := fmt.Sprintf("/service/%s/version/%d/logging/scalyr", i.ServiceID, i.ServiceVersion)
 	resp, err := c.PostForm(path, i, nil)
 	if err != nil {
@@ -180,6 +184,10 @@ func (c *Client) UpdateScalyr(i *UpdateScalyrInput) (*Scalyr, error) {
 		return nil, ErrMissingName
 	}
 
+	if i.Token != nil && *i.Token == "" {
+		return nil, ErrTokenEmpty
+	}
+
 	path := fmt.Sprintf("/service/%s/version/%d/logging/scalyr/%s", i.ServiceID, i.ServiceVersion, url.PathEscape(i.Name))
 	resp, err := c.PutForm(path, i, nil)
 	if err != nil {

fastly/splunk.go

@@ -108,6 +108,10 @@ func (c *Client) CreateSplunk(i *CreateSplunkInput) (*Splunk, error) {
 		return nil, ErrMissingServiceVersion
 	}
 
+	if i.Token == "" {
+		return nil, ErrMissingToken
+	}
+
 	path := fmt.Sprintf("/service/%s/version/%d/logging/splunk", i.ServiceID, i.ServiceVersion)
 	resp, err := c.PostForm(path, i, nil)
 	if err != nil {
@@ -201,6 +205,10 @@ func (c *Client) UpdateSplunk(i *UpdateSplunkInput) (*Splunk, error) {
 		return nil, ErrMissingName
 	}
 
+	if i.Token != nil && *i.Token == "" {
+		return nil, ErrTokenEmpty
+	}
+
 	path := fmt.Sprintf("/service/%s/version/%d/logging/splunk/%s", i.ServiceID, i.ServiceVersion, url.PathEscape(i.Name))
 	resp, err := c.PutForm(path, i, nil)
 	if err != nil {