Add Backends field to Director
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested review from
a team and
kailan
and removed request for
a team
Integralist
commented
Apr 27, 2022
Comment on lines
+24
to
+46
| b, errBackend = c.CreateBackend(&CreateBackendInput{ | ||
| ServiceID: testServiceID, | ||
| ServiceVersion: tv.Number, | ||
| Name: "test-backend", | ||
| Address: "integ-test.go-fastly.com", | ||
| Port: Uint(1234), | ||
| ConnectTimeout: Uint(1500), | ||
| OverrideHost: "origin.example.com", | ||
| SSLCiphers: "DHE-RSA-AES256-SHA:DHE-RSA-CAMELLIA256-SHA:AES256-GCM-SHA384", | ||
| }) | ||
| d, errDirector = c.CreateDirector(&CreateDirectorInput{ | ||
| ServiceID: testServiceID, | ||
| ServiceVersion: tv.Number, | ||
| Name: "test-director", | ||
| Quorum: Uint(50), | ||
| Type: DirectorTypeRandom, | ||
| Retries: Uint(5), | ||
| }) | ||
| _, errDirectorBackend = c.CreateDirectorBackend(&CreateDirectorBackendInput{ | ||
| ServiceID: testServiceID, | ||
| ServiceVersion: tv.Number, | ||
| Director: "test-director", | ||
| Backend: b.Name, |
There was a problem hiding this comment.
In the test suite I ensure when creating a Director we also create a Backend and then create a relationship between the two.
Comment on lines
+144
to
146
| if len(nb.Backends) == 0 || nb.Backends[0] != b.Name { | ||
| t.Error("bad backend: expected a backend") | ||
| } |
There was a problem hiding this comment.
This test assertion validates that the requested Director contains the Backend we expect it to.
|
cc @jdigory who reported this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The Fastly Terraform Provider is inefficiently checking for backend membership within a Director, resulting in API requests reaching 1000+ in some cases for customers.
Solution: Expose the
backendsfield on the director so that the Terraform Provider can quickly validate which service backends are members of the director.