Initial ERL support + redacted fixtures #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested changes
Mar 21, 2022
There was a problem hiding this comment.
Thanks @johnmcilwain for your patience waiting for me to review this PR.
I've a bunch of suggested edits. I would suggest running go fmt after applying them as the alignment of some struct fields will need fixing afterwards.
Let me know when you're ready for me to re-review and I'll take another look at the API logic (apologies but with all my suggested edits it was hard for me to go back and review the logic, my bad).
Integralist
reviewed
Mar 21, 2022
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Integralist
reviewed
Mar 23, 2022
Integralist
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Edge Rate Limiting
https://developer.fastly.com/reference/api/vcl-services/rate-limiter/