Fix issues with serialising x-www-form-urlencoded data + Change Backend SSLCiphers field from []string to string
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
commented
Sep 20, 2021
| form: | ||
| name: | ||
| - my-test-token-1 | ||
| password: | ||
| - foobar | ||
| scope: | ||
| - global | ||
| services[]: |
There was a problem hiding this comment.
Notice the VCR package now correctly marshals the values into the request body.
Integralist
commented
Sep 20, 2021
| url: https://api.fastly.com/tokens | ||
| method: POST | ||
| response: | ||
| body: '{"id":"67WnFZog4TztGgdNfc9mxX","name":"my-test-token-1","user_id":"52LiGaZmbWl4D5xv4tcxON","customer_id":"51MumwLiSJyFTWhtbByYgR","service_id":null,"expires_at":null,"created_at":"2021-09-15T16:10:56Z","updated_at":"2021-09-15T16:10:56Z","scope":"global","services":[],"access_token":"XXXXXXXXXXXXXXXXXXXXXX"}' | ||
| body: '{"id":"27DePetT24oLN9xdXRMkdo","name":"my-test-token-1","user_id":"52LiGaZmbWl4D5xv4tcxON","customer_id":"51MumwLiSJyFTWhtbByYgR","service_id":"6besTz8jIUQudhhr4vLEzt","expires_at":null,"created_at":"2021-09-20T11:24:38Z","updated_at":"2021-09-20T11:24:38Z","scope":"global","services":["5wHdzYhbILBcvU2aAjH8so","6besTz8jIUQudhhr4vLEzt"],"access_token":"XXXXXXXXXXXXXXXXXXXXXX"}' |
There was a problem hiding this comment.
Notice the API response now correctly includes a value for the services field.
Integralist
force-pushed
the
integralist/fix-urlencoding-for-arrays
branch
from
b4ecd86
to
f7b85ef
Compare
triblondon
approved these changes
Sep 21, 2021
doramatadora
approved these changes
Sep 21, 2021
Integralist
changed the title
SSLCiphers field from []string to string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foo|0=A&foo|1=Bformat doesn't work with our API endpoint, so switch tofoo[]=A&foo[]=B.