Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL entry Subnet should be integer type (missed references) #290

Merged
merged 2 commits into from
Jul 23, 2021
Merged

ACL entry Subnet should be integer type (missed references) #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b079674
subnet should be an int
Integralist Jul 23, 2021
99cc410
fix tests
Integralist Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fastly/acl_entry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ type CreateACLEntryInput struct {
IP string `form:"ip"`

// Optional fields
Subnet string `form:"subnet,omitempty"`
Subnet int `form:"subnet,omitempty"`
Negated bool `form:"negated,omitempty"`
Comment string `form:"comment,omitempty"`
}
Expand Down Expand Up @@ -191,7 +191,7 @@ type UpdateACLEntryInput struct {

// Optional fields
IP *string `form:"ip,omitempty"`
Subnet *string `form:"subnet,omitempty"`
Subnet *int `form:"subnet,omitempty"`
Negated *bool `form:"negated,omitempty"`
Comment *string `form:"comment,omitempty"`
}
Expand Down
2 changes: 1 addition & 1 deletion fastly/acl_entry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func TestClient_ACLEntries(t *testing.T) {
ServiceID: testService.ID,
ACLID: testACL.ID,
IP: "10.0.0.3",
Subnet: "8",
Subnet: 8,
Negated: false,
Comment: "test entry",
})
Expand Down