Add S3 Logging ACL parameter and add Redundancy options #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The S3 logging endpoint in the Fastly API supports an `acl` parameter which allows setting the permissions of the uploaded log objects within the bucket. This commit adds support for this to the SDK. The Fastly UI console suggests that there are 7 options for this based on the AWS "canned ACL"s, including "private", "public-read" etc. I have therefore used constants to represent these options, similarly to the redundancy parameters. Furthermore, there are 4 options for redundancy, but only two were previously supported by the SDK. I have added the two others for the infrequently accessed storage tiers.
Integralist
reviewed
Jun 9, 2021
There was a problem hiding this comment.
Thanks @bengesoff I have just one comment that needs some clarification (i.e. the 'struct field as a pointer' comment).
bengesoff
commented
Jun 10, 2021
Integralist
approved these changes
Jun 10, 2021
|
@bengesoff did you have any further changes. I'm happy to merge this if you're OK with it being merged. |
|
@Integralist I'm happy with it if you are! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The S3 logging endpoint in the Fastly API supports an
aclparameter which allows setting the permissions of the uploaded log objects within the bucket.This commit adds support for this to the SDK, as requested in #278.
The Fastly UI console suggests that there are 7 options for this based on the AWS "canned ACL"s, including "private", "public-read" etc, so I have added support for those.
Furthermore, there are 4 options for
redundancy, but only two were previously supported by the SDK.I have added the two others for the infrequently accessed storage tiers.
The API docs for s3 logging are here: https://developer.fastly.com/reference/api/logging/s3/
The test fixtures have a lot of changed timestamps and rate limit parameters in the diffs, but the main differences should be the
aclandredundancyparameters in the requests.I also added a couple of checks to the test to exercise the new options and verify that they were working.