Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more support for compression_codec to logging endpoints #257

Conversation

kellymclaughlin
Copy link
Contributor

Add support for compression_codec to the digitalocean and cloudfiles logging endpoints.

This expands the changes from #235 to two more endpoints.

Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two small test comments.

fastly/digitalocean_test.go Show resolved Hide resolved
fastly/cloudfiles_test.go Show resolved Hide resolved
@Integralist Integralist added the enhancement New feature or request label Feb 3, 2021
Add support for compression_codec to the digitalocean and cloudfiles logging endpoints.
@kellymclaughlin kellymclaughlin force-pushed the logging-compression-digitalocean-cloudfiles branch from 59c1572 to 867198e Compare February 3, 2021 18:07
@Integralist
Copy link
Collaborator

Thanks @kellymclaughlin I'll merge this tomorrow and cut a new release in my morning.

@Integralist Integralist merged commit daf0953 into fastly:master Feb 4, 2021
@kellymclaughlin kellymclaughlin deleted the logging-compression-digitalocean-cloudfiles branch April 13, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants