-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kinesis logging endpoint #234
Add support for Kinesis logging endpoint #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kellymclaughlin for this PR!
I've just some small comments and requested changes.
Updates to make kinesis logging use v2 conventions and some minor changes based on review feedback.
👋🏻 @kellymclaughlin I've been on paternity leave so I'm going to try and get round to re-reviewing this today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just a few minor comments.
No description provided.