Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MessageType field to GCS Updates #193

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Add MessageType field to GCS Updates #193

merged 1 commit into from
Jun 3, 2020

Conversation

mccurdyc
Copy link
Contributor

@mccurdyc mccurdyc commented Jun 3, 2020 •
edited
Loading

Proposed Change(s)

  • Add missing MessageType field to Updates.
  • Update integration test mock recordings for GCS.

Relevant Link(s) / Documentation:

Validation

$ rm -rf fastly/fixtures/gcses
$ export FASTLY_TEST_SERVICE_ID=<foo>
$ export FASTLY_API_KEY=<foo>
$ make test-full TESTARGS="-run=GCS -count=1"
$ make test TESTARGS="-run=GCS -count=1"
$ make fix-fixtures
$ unset FASTLY_TEST_SERVICE_ID FASTLY_API_KEY
$ make test

@mccurdyc
gcs: add MessageType field to Updates
7b43a1f 
Signed-off-by: Colton J. McCurdy <cmccurdy@fastly.com>
@mccurdyc mccurdyc requested review from ezkl and phamann June 3, 2020 13:38
mccurdyc
mccurdyc commented Jun 3, 2020
View reviewed changes
fastly/fixtures/gcses/update.yaml
interactions:
- request:
body: Name=test-gcs&Service=7i6HN3TK9wS159v2gPAZ8A&Version=67&name=new-test-gcs
body: Name=test-gcs&Service=7i6HN3TK9wS159v2gPAZ8A&Version=6&message_type=classic&name=new-test-gcs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New message_type field.

mccurdyc
mccurdyc commented Jun 3, 2020
View reviewed changes
fastly/fixtures/gcses/update.yaml
PRIVATE KEY-----\nMIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQC9aQoqdHVA86oq\nTdRQ5HqwMfpiLBBMKNQcAJsO71RKNrDWwJJZiyYbvM4FOWRZFtRSdPIDgX0C0Wg1\nNnqWYvHDyA5Ug+T8kowiQDn56dU6Km2FWO4wnqZeA8q5G7rQVXlqdibuiP7FglHA\neURUzFsqyymXMUGrqDPqrHsVWC2E3NTJEb4QlywtrwI13qbhlvTx6/9oRfUjytXJ\nRuUIE5xL8yhRCagNr5ZW250aa+wBwu5DSCk5fDNr0eDuZjw84WHDll+mHxBFGV+X\nKJ5jCOmGumGqjVWZesJpNN1My3M9bsY9layNJJ0eiDeHDEi/yXhhO/mNEXhvhq/R\nfN0Jh2A3AgMBAAECggEAef+CEL5aF6/aVs0yh7fiXkKSp1ECXkud8ztgpEn63KJF\nXM1EdnBt50fA2xSQUeGmeEXi6+cngf0nRb8FToAEgLoGoOEjSJuLrzP3I8U9Fe3m\nBRG2uZI2Ti/bD0eRGEc1oSDhCpsqnkTGK1bwcD4AKpwY+c08Izh/2BOoY6McDoqh\ndQ89jzTuMtD4cNlnPiIrY9HbxoNjshK2ax1OaeXyYKZFG1TxqMFv5gA/G5+S3Cwr\nVG4fkAxYi5vdIK3b8jUXrTM/kpoTl+d3dlQ7rRZYf7KyT31/HtJ/GNzxFI6upzO7\niDNrrUOyeOPjWXdzUh9budv3j+6UfbYK7uZIoebHIQKBgQDykYX1L/akGaOC2tfS\njzCWUzPxGFYVZQ7zD1PM6UyouuS1KLURDEGk9RxqVzTPh/pYd8Ivnz3vOVski5Zt\n19ozLGxdtDhn122DcnVpfCdYzHBdAzPCzORenFohX+MhiX5fEotTlVi7wfOmzTP5\nhUCMSd/17bJrV4XMLhkdrMRBFQKBgQDH5fwV7o+Ej/ZfcdGIa3mAFazToPDzxhHU\nnwADxaxpNGKRU03XCaiYkykarLYdG6Rk+7dXUv8eLy+6Dcq1SWQtfCWKEor++IIp\n1RwWmFHfYriHGkmxSkkEkLFvL8old9xM5YWbEXc4QIXvnfR4BZxdyJHVzIDdbI2i\nFgcn17U3GwKBgDd1njMY7ENIuWHJt16k7m7wRwfwkH4DxQ89ieNn0+cgE/p3fC6R\nptCYWg7WMXThmhNwDi3lMrvnWTdZ0uL6XyEkHwKtmdfkIV3UZZPglv5uf6JEgSkg\nv3YCOXk3+y5HyWTjUIejtc334kVY1XFPThrFKTeJSSnRsP2l7IgkYBqhAoGAYGsr\nM3z1FrDF2nWw5odIfKJ30UAw2LRyB0eGH0uqhLgyzvwKcK2E98sLqYUi9llN6zOK\n1IEA8xM5hxl97AFxY4sdJEMbbi55wim7uZ5Q51nbvbbNUsmM/Lm6C/JWI8pzpVeU\nIR7EjYp50AE1WOsD6CyFQ0W35pWkn0jWvL4L938CgYEAlax4dLE5+YCG5DeLT1/N\nin6kQjl7JS4oCNlPEj6aRPLX2OJresI7oOn+uNatKvlVyfPm6rdxeHCmER1FpR7Q\nA/aNVjPeViKT/R4nK9ytsa+s/1IJVrwLFHJK3toGE660g5w3vKrCjWisMdP4yzzQ\nbv1KwcKoQbNVXwauH79JKc0=\n-----END
PRIVATE KEY-----\n"}'
PRIVATE KEY-----\n","period":"12","format_version":"2","name":"new-test-gcs","version":"6","created_at":"2020-06-03T13:25:53Z","deleted_at":null,"service_id":"7i6HN3TK9wS159v2gPAZ8A","timestamp_format":"%Y","message_type":"classic","placement":"waf_debug","updated_at":"2020-06-03T13:25:53Z","gzip_level":"9","public_key":null,"user":"user"}'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New message_type field

@mccurdyc mccurdyc marked this pull request as ready for review June 3, 2020 13:45
@mccurdyc mccurdyc added the enhancement New feature or request label Jun 3, 2020
ezkl
ezkl approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@ezkl ezkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mccurdyc mccurdyc merged commit 4cea8fd into fastly:master Jun 3, 2020
@mccurdyc mccurdyc deleted the mccurdyc/gcs-update-messagetype branch June 3, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezkl ezkl ezkl approved these changes

@phamann phamann Awaiting requested review from phamann

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccurdyc @ezkl