Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTPS logging endpoints #155

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Add support for HTTPS logging endpoints #155

merged 1 commit into from
Apr 22, 2020

Conversation

ezkl
Copy link
Contributor

@ezkl ezkl commented Apr 21, 2020

See the docs for more information on HTTPS log streaming.

Copy link
Contributor

@mccurdyc mccurdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments. Overall, looks good.

fastly/https.go Outdated Show resolved Hide resolved
fastly/https.go Show resolved Hide resolved
fastly/https.go Show resolved Hide resolved
fastly/https.go Show resolved Hide resolved
fastly/https.go Show resolved Hide resolved
fastly/https_test.go Show resolved Hide resolved
fastly/https_test.go Show resolved Hide resolved
HTTPS log endpoints are currently in Limited Availability. See the docs
for more information: https://docs.fastly.com/en/guides/log-streaming-https
Copy link
Contributor

@mccurdyc mccurdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Thank you for contributing this so quickly.

@ezkl ezkl merged commit 8f30fa4 into fastly:master Apr 22, 2020
@ezkl ezkl deleted the ezkl/add-https-logging branch April 22, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants