Refactor cache tag adjustment logic #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g result via layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the default Magento Varnish setup, Fastly does not use
,as a cache tag separator, but rather spaces. This is being adjusted in one of the plugins:https://github.com/fastly/fastly-magento2/blob/master/Model/Layout/LayoutPlugin.php#L112
However, the code above relays on premise that output will be always rendered via layout, which is not the case for ESI blocks:
https://github.com/magento/magento2/blob/2.2.0-rc2.3/app/code/Magento/PageCache/Controller/Block/Esi.php#L16-L34
As a result, any ESI block that had more than one cache tag was not invalidated properly.
Considering the above, code has been changed to utilize the plugin around the
setHeader()to do the changes, which covers every case(if development is done following the Magento practices)