Support cargo workspaces #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfx
force-pushed
the
gfx/support-workspaces
branch
from
23bf500 to
a72898d
Compare
phamann
approved these changes
Nov 24, 2020
| } | ||
|
|
||
| // Read the contents of the Cargo.lock file from filename. | ||
| func (m *CargoMetadata) Read() error { | ||
| cmd := exec.Command("cargo", "metadata", "--format-version", "1") | ||
| cmd := exec.Command("cargo", "metadata", "--quiet", "--format-version", "1") |
There was a problem hiding this comment.
What is the reason for adding the --quiet flag here?
There was a problem hiding this comment.
It suppresses some warnings, esp. for workspaces, like:
$ cargo metadata --format-version 1 > /dev/null
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package: /Users/goro-fuji/ghq/github.com/gfx/ecp-hello/app/Cargo.toml
workspace: /Users/goro-fuji/ghq/github.com/gfx/ecp-ecp-hello/Cargo.toml
It doesn't affect the fastly cli but I feel it's better to suppress.
phamann
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #171, as @pchickey suggested in #171 (comment)
Confirmed I can build and deploy https://github.com/fastly/ecp-workspace-example