Add AssemblyScript support to compute init and build commands #160
Conversation
phamann
force-pushed
the
phamann/assemblyscript
branch
from
e763109 to
2fe6fc8
Compare
pkg/compute/build.go
Outdated
| type Toolchain interface { | ||
| Name() string | ||
| DisplayName() string | ||
| StarterKits() []StarterKit | ||
| SourceDirectory() string | ||
| IncludeFiles() []string | ||
| Initialize(out io.Writer) error | ||
| Verify(out io.Writer) error | ||
| Build(out io.Writer, verbose bool) error | ||
| } |
There was a problem hiding this comment.
I don't like the use of interface methods here to model getters for simple values. Would this be better modelled as a Language struct with an embedded Toolchain interface? Such as:
| type Toolchain interface { | |
| Name() string | |
| DisplayName() string | |
| StarterKits() []StarterKit | |
| SourceDirectory() string | |
| IncludeFiles() []string | |
| Initialize(out io.Writer) error | |
| Verify(out io.Writer) error | |
| Build(out io.Writer, verbose bool) error | |
| } | |
| type Toolchain interface { | |
| Initialize(out io.Writer) error | |
| Verify(out io.Writer) error | |
| Build(out io.Writer, verbose bool) error | |
| } | |
| type Language struct { | |
| Name string | |
| DisplayName string | |
| StarterKits []StarterKit | |
| IncludeFiles []string | |
| Toolchain | |
| } | |
| func NewLangauge(name, displayName, string, kits []starterKits, includeFiles []string, toolchain Toolchain) *Language { | |
| // ... etc | |
| } |
There was a problem hiding this comment.
NewLangauge -> NewLanguage in your suggestion :)
I personally like the Language struct idea because this NewLanguage function could be where the "metadata"-y bits that I was talking about could be initialized and verified.
There was a problem hiding this comment.
@phamann I like your alternative — structs collect data, and interfaces collect behavior, so your type Language struct seems to best model what's actually going on.
There was a problem hiding this comment.
Ok @mccurdyc @peterbourgon Have implemented this in 5d59eb8 let me know your thoughts?
pkg/compute/assemblyscript.go
Outdated
| // Check if bin directory exists and create if not. | ||
| pwd, err := os.Getwd() | ||
| if err != nil { | ||
| return fmt.Errorf("error getting current working directory: %w", err) | ||
| } | ||
| binDir := filepath.Join(pwd, "bin") | ||
| if err := common.MakeDirectoryIfNotExists(binDir); err != nil { | ||
| return fmt.Errorf("error making bin directory: %w", err) | ||
| } | ||
|
|
||
| npmdir, err := getNpmBinPath() | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
suggestion - thoughts on pulling these "metadata"-y bits into some centralized "initialization" function that gets called once and sets some "metadata" fields on like a config struct or something so that we don't have to have these checks in multiple places.
An additional benefit of this would be that the functions are more focused on what they are supposed to be doing --- e.g., "building" --- and less on validating the environment.
A valid counter argument to this would be then you have dependencies on the metadata fields being set and the functions --- e.g., Build --- are not entirely self-contained.
pkg/compute/build.go
Outdated
| type Toolchain interface { | ||
| Name() string | ||
| DisplayName() string | ||
| StarterKits() []StarterKit | ||
| SourceDirectory() string | ||
| IncludeFiles() []string | ||
| Initialize(out io.Writer) error | ||
| Verify(out io.Writer) error | ||
| Build(out io.Writer, verbose bool) error | ||
| } |
There was a problem hiding this comment.
NewLangauge -> NewLanguage in your suggestion :)
I personally like the Language struct idea because this NewLanguage function could be where the "metadata"-y bits that I was talking about could be initialized and verified.
Co-authored-by: Colton J. McCurdy <cmccurdy@fastly.com>
TL;DR
Adds beta AssemblyScript toolchain support to the Compute@Edge commands
fastly compute initandfastly compute build. It usesnpmto validate the package and environment and theasctoolchain for compilation.What
pkg/compute/init.goandpkg/compute/build.goto support multiple languages.pkg/common/exec.Toolchaininterface to better cater for multiple languages.pkg/compute/rust.goto support new toolchain interface additions.Toolchaininterface.