-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service search command #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your speedy contribution, @benzvan! Much appreciated.
Looks clean overall, just a couple of changes needed:
- We don't need to interact with the
manifest
for this command - You'll need to update the help output intergration test in
pkg/app/run_test.go
- You need to fix some linting errors via
make fmt
.
Thanks for the fast feedback. I'm working on your change requests and it looks like I'll have to dig in and understand the code a little more than copy/paste/rename :-D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fixing some style consistency, I didn't notice originally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Once again thank you for your contribution @benzvan!
No problem. I'll start looking at the next issue i created today. |
This adds the ability to call the
service/search?name=
endpoint to return service descriptions without the service ID.Issue #151