Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the correct version number on error #144

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

fgsch
Copy link
Member

@fgsch fgsch commented Jul 17, 2020

Before this change, the message said:

"[..] are identical. (service 3kky3wMojmJHi3sQa3hun5, version {{false} 0})"

Before this change, the message said:

"[..] are identical. (service 3kky3wMojmJHi3sQa3hun5, version {{false} 0})"
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for finding and fixing this!

@phamann phamann merged commit 5fea42b into master Jul 20, 2020
@phamann phamann deleted the fgsch/fix-version-number branch July 20, 2020 13:36
@phamann phamann added the bug Something isn't working label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants