Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compute/serve): don't fail the serve workflow if github errors #1246

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix(compute/serve): don't fail the serve workflow if github errors #1246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/commands/compute/serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,8 @@ func (c *ServeCommand) InstallViceroy(
// IMPORTANT: We declare separately so to shadow `err` from parent scope.
var latestVersion string

// NOTE: We won't stop the user because although we can't request the latest
// version of the tool, the user may have a local version already installed.
err = spinner.Process("Checking latest Viceroy release", func(_ *text.SpinnerWrapper) error {
latestVersion, err = c.ViceroyVersioner.LatestVersion()
if err != nil {
Expand All @@ -487,7 +489,7 @@ func (c *ServeCommand) InstallViceroy(
return nil
})
if err != nil {
return err
return nil // short-circuit the rest of this function
}

viceroyConfig := c.Globals.Config.Viceroy
Expand Down