fix(service-version): Allow 'locked' services to be activated.

[kpfleming]

This PR changes the ServiceDetailsOpts structure (used by the ServiceDetails function) to permit commands to specify individual service states as part of the filtering mechanism. Nearly all commands allow both 'active' and 'locked' services, and previously 'service-version activate' blocked both, but it should allow 'locked' while still blocking 'active'.

Additionally, the error message emitted when the specified service is not allowed by the filter now indicates whether it was the 'active' or 'locked' status which caused the error.

Closes #1191.

[Integralist]

It looks like a third-party dependency has been manually copied into the repo?

From what I can tell the original code came from https://github.com/leighmcculloch/go-optional

We should be adding this as a dependency to the CLI go.mod

e.g. go get https://github.com/leighmcculloch/go-optional@latest followed by go mod tidy once the dependency is referenced in the codebase itself)

[kpfleming]

The new package has now been added to go.mod as a normal dependency.

[kpfleming]

Unfortunately go mod tidy is not happy about the replace specification.

[Integralist]

I'll take a look on Monday and see what we can do

[Integralist]

Other than the issue with go mod tidy which I'll look at Monday, this LGTM

[Integralist]

Yeah I think we'll just have to use the import path used in that optional project...

diff --git a/go.mod b/go.mod
index b1c9b1bc..aaed6c53 100644
--- a/go.mod
+++ b/go.mod
@@ -79,8 +79,4 @@ require (
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
 
-require (
-    github.com/leighmcculloch/go-optional v0.2.0
-)
-
-replace github.com/leighmcculloch/go-optional => 4d63.com/optional v0.2.0
+require 4d63.com/optional v0.2.0

diff --git a/pkg/argparser/cmd.go b/pkg/argparser/cmd.go
index 50e9ce62..3be4104b 100644
--- a/pkg/argparser/cmd.go
+++ b/pkg/argparser/cmd.go
@@ -13,7 +13,7 @@ import (
 	"github.com/fastly/cli/pkg/global"
 	"github.com/fastly/cli/pkg/manifest"
 	"github.com/fastly/cli/pkg/text"
-	optional "github.com/leighmcculloch/go-optional"
+	"4d63.com/optional"
 )

[kpfleming]

I know there are strong opinions about this topic, and I'm fairly new to the Golang community, but how would you feel about using 'go mod vendor' here? I'm mostly concerned about build reproducibility. Most of our dependencies are heavily-used packages and aren't likely to be a problem, but this one (optional) is not and could disappear.

[kpfleming]

After discussion with various knowledgeable Go users we've decided to stick with the 'vanity path' used for the optional module.