Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add project-id to gcs logging setting #1202

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

noguxun
Copy link
Contributor

@noguxun noguxun commented May 9, 2024

Done following tests

./fastly logging gcs create --name gcs4 \
--account-name test-account-id \
--bucket test-bucket-name \
--project-id test-project-id \
--path test-path \
--service-id $MY_SID --version $MY_VER --profile noguxun


./fastly logging gcs update --name gcs4 \
--project-id test-project-id-modified \
--path test-path-modified \
--service-id $MY_SID --version $MY_VER --profile noguxun


make test TEST_ARGS="-run TestGCSCreate ./pkg/commands/logging/gcs"

@Integralist
Copy link
Collaborator

Integralist commented May 9, 2024

@noguxun LGTM but the CI tests are failing (see screenshot)

Monosnap add project-id to gcs logging setting · fastly:cli@3ba2308 2024-05-09 10-52-21

@noguxun
Copy link
Contributor Author

noguxun commented May 9, 2024

@Integralist , thanks for the review! I've just fixed the issue, the PR passed the CI now.

@Integralist Integralist merged commit 7b1920e into fastly:main May 9, 2024
6 checks passed
@Integralist Integralist added the enhancement New feature or request label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants