Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compute/deploy): avoid store conflicts #1041

Merged
merged 23 commits into from
Oct 17, 2023
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
9f1b110
refactor(compute/deploy): rename test case
Integralist Oct 11, 2023
080044a
fix(compute/deploy): pass user's prompt input rather than the configu…
Integralist Oct 11, 2023
f23d93d
feat(compute/deploy): avoid kv store conflicts
Integralist Oct 11, 2023
ea43820
refactor(compute/deploy): use spinner.Process abstraction
Integralist Oct 11, 2023
4043738
feat(compute/deploy): avoid config store conflicts
Integralist Oct 11, 2023
f61875f
feat(compute/deploy): avoid secret store conflicts
Integralist Oct 11, 2023
9907bd4
refactor(compute/deploy): uppercase KV Store
Integralist Oct 12, 2023
4b96153
doc(release): explain manifest documentation
Integralist Oct 12, 2023
4646286
tests(compute/deploy): define secret store tests
Integralist Oct 12, 2023
db3dfc6
refactor(compute/deploy): sort api fields
Integralist Oct 12, 2023
763f1f0
fix(compute/deploy): display version number
Integralist Oct 12, 2023
aea14a6
refactor: clean up text.Break
Integralist Oct 12, 2023
cbad342
fix(compute/deploy): pass through Store ID
Integralist Oct 12, 2023
068ba19
fix(text): adjust prompt colors
Integralist Oct 13, 2023
ad8e9f4
fix(compute/deploy): avoid config store key conflicts
Integralist Oct 13, 2023
84d29d3
refactor(cmd): make output an info message
Integralist Oct 13, 2023
d3d4b39
doc(compute/deploy): document special case for package comparison
Integralist Oct 13, 2023
e7d4690
fix(dictionary): update test output assertion
Integralist Oct 13, 2023
53de04b
fix(compute/deploy): remove unnecessary line break
Integralist Oct 13, 2023
5c9e489
feat(compute/deploy): support signal termination
Integralist Oct 17, 2023
e7722ae
fix(compute/deploy): notify users of upsert operation
Integralist Oct 17, 2023
2eb171c
fix(compute/deploy): use correct value for abs path
Integralist Oct 17, 2023
68027e8
refactor(compute/deploy): move upsert message to main warning
Integralist Oct 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(compute/deploy): display version number
  • Loading branch information
Integralist committed Oct 16, 2023

Verified

This commit was signed with the committer’s verified signature.
abernix Jesse Rosenberger
commit 763f1f0ca1daaa3dd9b83e124aaf7f144d008813
2 changes: 1 addition & 1 deletion pkg/commands/compute/deploy.go
Original file line number Diff line number Diff line change
@@ -188,7 +188,7 @@ func (c *DeployCommand) Exec(in io.Reader, out io.Writer) (err error) {
serviceVersion, err = c.ExistingServiceVersion(serviceID, out)
if err != nil {
if errors.Is(err, ErrPackageUnchanged) {
text.Info(out, "Skipping package deployment, local and service version are identical. (service %v, version %v) ", serviceID, serviceVersion)
text.Info(out, "Skipping package deployment, local and service version are identical. (service %s, version %d) ", serviceID, serviceVersion.Number)
return nil
}
return err