[snapshot] added 10 second timeout to wait for device to fully boot before overriding status bar (adjust by setting SNAPSHOT_SIMULATOR_WAIT_FOR_BOOT_TIMEOUT environment variable) #19380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efore overriding status bar (adjust by setting SNAPSHOT_SIMULATOR_WAIT_FOR_BOOT_TIMEOUT environment variable)
joshdholtz
deleted the
joshdholtz-snapshot-override-status-bar-sim-boot-timeout
branch
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.195.0 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Follow up to #19344. Turns out that this mostly works but not fully. The "Booted" status can still show while the simulator is booting (Apple logo showing). This "Booting" status doesn't allow the status bar to be overridden.
Description
Adds a sleep after trying to boot the simulator to make sure device is fully operational before attempting to set the status bar. Can be adjusted using the
SNAPSHOT_SIMULATOR_WAIT_FOR_BOOT_TIMEOUTenvironemtn variable. Defaults to 10 seconds.Testing Steps
Update
Gemfileand runbundle install,bundle update fastlane, orbundle update