Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mongo workflow #59

Merged
merged 5 commits into from
Aug 11, 2022
Merged

add mongo workflow #59

merged 5 commits into from
Aug 11, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 11, 2022

Checklist

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 11, 2022

Should we use mongo 6? Should we add parameters?

@Uzlopak Uzlopak requested review from Eomm and Fdawgs August 11, 2022 06:33
@climba03003
Copy link
Member

Should we use mongo 6? Should we add parameters?

I would check both version.
But from my experience, server version shouldn't makes different since we check the connection only in @fastify/mongodb.

Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 11, 2022

There is no official mongo:6.0.0 docker image it seems like. So nevermind :)

@Uzlopak Uzlopak requested a review from Fdawgs August 11, 2022 07:00
@Uzlopak Uzlopak merged commit a85d606 into fastify:main Aug 11, 2022
@Uzlopak Uzlopak deleted the add-mongo branch August 11, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants