Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): replace standard with neostandard #282

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Dec 8, 2024

See fastify/fastify-cors#340. This is a batch PR, so may have some issues. Please review changes.

@Fdawgs Fdawgs changed the title chore: add eslint.config.js build(deps-dev): replace standard with neostandard Dec 8, 2024
@Fdawgs
Copy link
Member Author

Fdawgs commented Dec 9, 2024

Test failures related to fastify/fastify#5637, TypeScript tests and/or types need updating to include required plugin params.

@Uzlopak
Copy link
Contributor

Uzlopak commented Dec 9, 2024

Do we need to wait for a release of fastify or do we need to fix something on plugin level?

@Fdawgs
Copy link
Member Author

Fdawgs commented Dec 9, 2024

Do we need to wait for a release of fastify or do we need to fix something on plugin level?

This is something we need to fix in the plugins. Either our type tests are missing mandatory/required plugin options, or the plugin option types are wrong and there are options that are required that should be optional.

See fastify/fastify-accepts#178 and fastify/fastify-autoload#425 where I've fixed it.

@Fdawgs Fdawgs merged commit 4b996a3 into master Dec 12, 2024
13 checks passed
@Fdawgs Fdawgs deleted the build/standard branch December 12, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants