Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use lowercase for charset #92

Merged
merged 1 commit into from
Nov 18, 2024
Merged

refactor: use lowercase for charset #92

merged 1 commit into from
Nov 18, 2024

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Nov 18, 2024

Whilst the content-type response header is case-insensitive, lowercase is preferred, as per RFC 9110 Section 8.3.1.

It's very rare to see any sites using uppercase anymore.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fdawgs
Copy link
Member Author

Fdawgs commented Nov 18, 2024

I've noticed in that RFC it also states that no whitespace is also preferred, so text/plain;charset=utf-8 over text/plain; charset=utf-8. Is that also worth changing here?

@mcollina mcollina merged commit 6f078bb into master Nov 18, 2024
16 checks passed
@Eomm Eomm deleted the ref/charset branch November 18, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants