Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate range-parser #30

Merged
merged 2 commits into from
Jan 17, 2023
Merged

integrate range-parser #30

merged 2 commits into from
Jan 17, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jan 17, 2023

Integrates range-parser, modified for only our use case by combining the ranges.

My gut says, that we potentially can optimize parseRange but I have not the right angle yet.

Checklist

@Uzlopak Uzlopak requested review from mcollina and Eomm January 17, 2023 10:20
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit ff81e96 into master Jan 17, 2023
@Uzlopak Uzlopak deleted the integrate-range-parser branch January 17, 2023 10:54
@gurgunday
Copy link
Member

gurgunday commented Jan 17, 2023

Bless you @Uzlopak

I aspire to your relentless dedication to improving the Fastify ecosystem.

Nit but maybe the benchmark package should be in devDeps?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jan 17, 2023

Thank you.

Yes the Benchmark package should be in devdependencies.
I am currently integrating the fresh package. Will provide a fix up PR after that.

@Uzlopak Uzlopak mentioned this pull request Jan 17, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants