Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove statuses package, precompute html errors #17

Merged
merged 2 commits into from
Jan 14, 2023
Merged

remove statuses package, precompute html errors #17

merged 2 commits into from
Jan 14, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jan 13, 2023

Removes the statuses package. We also precompute the html errors. Not benchmarke, but it should bring a perf boost.

Checklist

@Uzlopak Uzlopak requested a review from mcollina January 13, 2023 17:54
@Uzlopak Uzlopak marked this pull request as draft January 13, 2023 19:43
@Uzlopak Uzlopak marked this pull request as ready for review January 14, 2023 00:03
@Uzlopak Uzlopak requested a review from kibertoad January 14, 2023 00:03
mcollina
mcollina approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ae3d3d9 into master Jan 14, 2023
@Uzlopak Uzlopak deleted the remove-statuses branch January 14, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@kibertoad kibertoad Awaiting requested review from kibertoad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @mcollina