remove backwards compatibilty of dotfiles (#22)

fastify · Jan 14, 2023 · 3d6de26 · 3d6de26
1 parent 9f0df93
commit 3d6de26
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 24 deletions.
diff --git a/index.js b/index.js
@@ -120,11 +120,6 @@ function SendStream (req, path, options) {
     throw new TypeError('dotfiles option must be "allow", "deny", or "ignore"')
   }
 
-  // legacy support
-  if (opts.dotfiles === undefined) {
-    this._dotfiles = undefined
-  }
-
   this._extensions = opts.extensions !== undefined
     ? normalizeList(opts.extensions, 'extensions option')
     : []
@@ -481,16 +476,8 @@ SendStream.prototype.pipe = function pipe (res) {
 
   // dotfile handling
   if (containsDotFile(parts)) {
-    let access = this._dotfiles
-
-    if (access === undefined) {
-      access = parts[parts.length - 1][0] === '.'
-        ? 'ignore'
-        : 'allow'
-    }
-
-    debug('%s dotfile "%s"', access, path)
-    switch (access) {
+    debug('%s dotfile "%s"', this._dotfiles, path)
+    switch (this._dotfiles) {
       case 'allow':
         break
       case 'deny':

diff --git a/test/send.test.js b/test/send.test.js
@@ -163,7 +163,7 @@ test('send(file, options)', function (t) {
   })
 
   t.test('dotfiles', function (t) {
-    t.plan(6)
+    t.plan(5)
 
     t.test('should default to "ignore"', function (t) {
       t.plan(1)
@@ -173,14 +173,6 @@ test('send(file, options)', function (t) {
         .expect(404, err => t.error(err))
     })
 
-    t.test('should allow file within dotfile directory for back-compat', function (t) {
-      t.plan(1)
-
-      request(createServer({ root: fixtures }))
-        .get('/.mine/name.txt')
-        .expect(200, /tobi/, err => t.error(err))
-    })
-
     t.test('should reject bad value', function (t) {
       t.plan(1)