Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci!: migrate to fastify reusable workflow #52

Merged
merged 2 commits into from
May 31, 2022
Merged

ci!: migrate to fastify reusable workflow #52

merged 2 commits into from
May 31, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented May 30, 2022

BREAKING CHANGE: drops support for node 10 and 12; adds support for node 18

Checklist

mcollina
mcollina approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

CI is failing

@Fdawgs
Copy link
Member Author

Fdawgs commented May 30, 2022

CI is failing

Triggered a few reruns and it continues to fail, seems to be an issue with connecting to github.com during npm i, will revisit tomorrow.

@Fdawgs Fdawgs self-assigned this May 30, 2022
@Fdawgs Fdawgs changed the title ci!: migrate to fastify reusable workflow ci!: bring into line with reusable workflow May 31, 2022
@Fdawgs Fdawgs changed the title ci!: bring into line with reusable workflow ci!: migrate to fastify reusable workflow May 31, 2022
@Fdawgs
Copy link
Member Author

Fdawgs commented May 31, 2022 •
edited
Loading

@mcollina got it, was the use of the deprecated git:// protocol in the pre-commit devDependency

@Fdawgs Fdawgs merged commit 2532ae5 into main May 31, 2022
@Fdawgs Fdawgs deleted the Fdawgs-patch-1 branch May 31, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees

@Fdawgs Fdawgs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdawgs @mcollina