-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for eta@3.x #377
Merged
mcollina
merged 1 commit into
fastify:master
from
multivoltage:feature/etajs-3.0-support
Jun 30, 2023
Merged
feat: add support for eta@3.x #377
mcollina
merged 1 commit into
fastify:master
from
multivoltage:feature/etajs-3.0-support
Jun 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@mcollina |
why? |
Honestly I don't know. Is my second time I submit a pr ;) |
ddadaal
referenced
this pull request
in PKUHPC/OpenSCOW
Jul 4, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/view](https://togithub.com/fastify/point-of-view) | [`7.4.1` -> `8.0.0`](https://renovatebot.com/diffs/npm/@fastify%2fview/7.4.1/8.0.0) | [![age](https://badges.renovateapi.com/packages/npm/@fastify%2fview/8.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@fastify%2fview/8.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@fastify%2fview/8.0.0/compatibility-slim/7.4.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@fastify%2fview/8.0.0/confidence-slim/7.4.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/point-of-view (@​fastify/view)</summary> ### [`v8.0.0`](https://togithub.com/fastify/point-of-view/releases/tag/v8.0.0) [Compare Source](https://togithub.com/fastify/point-of-view/compare/v7.4.1...v8.0.0) #### What's Changed - build(deps-dev): bump eta from 1.14.2 to 2.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/point-of-view/pull/364](https://togithub.com/fastify/point-of-view/pull/364) - chore(.gitignore): add bun lockfile by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/point-of-view/pull/366](https://togithub.com/fastify/point-of-view/pull/366) - build(deps-dev): bump tsd from 0.25.0 to 0.26.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/point-of-view/pull/367](https://togithub.com/fastify/point-of-view/pull/367) - build(deps-dev): bump tsd from 0.26.1 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/point-of-view/pull/368](https://togithub.com/fastify/point-of-view/pull/368) - build(deps-dev): bump tsd from 0.27.0 to 0.28.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/point-of-view/pull/369](https://togithub.com/fastify/point-of-view/pull/369) - ci: only trigger on pushes to main branches by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/point-of-view/pull/370](https://togithub.com/fastify/point-of-view/pull/370) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.16.5 to 20.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/point-of-view/pull/371](https://togithub.com/fastify/point-of-view/pull/371) - feat: add support for eta@3.x by [@​multivoltage](https://togithub.com/multivoltage) in [https://github.com/fastify/point-of-view/pull/377](https://togithub.com/fastify/point-of-view/pull/377) #### New Contributors - [@​multivoltage](https://togithub.com/multivoltage) made their first contribution in [https://github.com/fastify/point-of-view/pull/377](https://togithub.com/fastify/point-of-view/pull/377) **Full Changelog**: fastify/point-of-view@v7.4.1...v8.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on sunday" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/PKUHPC/SCOW). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
I have issue, this PR doesn't work if eta using includeFile. |
Please open a new detailed issue adding a Minimal, Reproducible Example. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct
Goal
I want etajs@3.x support for this project. Hope my PR or other people want same feature
What I did not
Not edited documentation since probably I cannot say to be skilled enough in this project
What I did
I tried to make all the tests work by changing as few things as possible. Unfortunately, one big change involves creating an Eta instance with new Eta().
I had to change many parts of the tests. Not sure about many changes. Finally I started a test project by installing fastify, and linking index.js. I managed to get the basic example working: