Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename module #325

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Rename module #325

merged 2 commits into from
Jun 7, 2022

Conversation

RafaelGSS
Copy link
Member

This pull request renames the module according to the discussion in
fastify/fastify#3733.

Note that the deprecation module has already been published and that the
code for it does not exist in this repository. The code for the published
deprecation module was generated by https://github.com/fastify/deprecate-modules
and run on @RafaelGSS local system.

Coordinating the drastic changes to the code for the module deprecation and
then restoring the code for the module renaming would have been extremely
difficult and prohibitively tedious.

Important: no further releases should be added to the old major version.

This commit renames the module in accordance with the discussion in
fastify/fastify/issues/3733 .
Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please get the plugin name as well? 😸

https://github.com/fastify/point-of-view/blob/master/index.js#L739

@RafaelGSS RafaelGSS requested a review from Fdawgs June 7, 2022 17:58
Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RafaelGSS RafaelGSS merged commit 560461f into master Jun 7, 2022
@Fdawgs Fdawgs deleted the rename-module branch June 8, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants