Pass cache option to eta engine

[erming]

Hello maintainers,

While using this plugin with the https://github.com/eta-dev/eta template engine, I noticed that NODE_ENV=production never cached the templates.

After some digging I found the culprit:

• point-of-view never sends the { cache: true } option to the eta engine

This pull request solves this.

app.register(require("point-of-view"), {
  engine: {
    eta: require("eta")
  },
  options: {
    cache: true // This variable is now set by NODE_ENV=production
  }
});

It can also be enabled by passing production: true to the engine.

Benchmark

Rendering a simple template with NODE_ENV=production

// index.js
app.register(require("point-of-view"), {
  engine: {
    eta: require("eta")
  }
});
app.get("/", async (req, res) => {
  res.view("view", {
    items: ["a", "b", "c"]
  });
});

// view.eta
<ul class="items">
  <% for (let item of it.items) { %>
    <li><%= item %></li>
  <% } %>
</ul>

Performance improvements:

$ autocannon -c 100 -d 5 -p 10 localhost:8000

— Before:   32k requests in 5.03s,  7.4 MB read
— After:   252k requests in 5.03s, 60.4 MB read

Checklist

• run npm run test
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[Fdawgs]

LGTM.

For reference for other reviewers: https://eta.js.org/docs/api/configuration

[Eomm]

Could you add a test like this one to verify this new default value?

point-of-view/test/test-eta.js

Line 803 in f218d2e

test('fastify.view with eta engine and custom cache', t => {

[erming]

Could you add a test like this one to verify this new default value?

point-of-view/test/test-eta.js

Line 803 in f218d2e

test('fastify.view with eta engine and custom cache', t => {

Done!

[climba03003]

LGTM.