Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name to plugin (#1) #199

Merged
merged 4 commits into from
Jan 6, 2021
Merged

Add name to plugin (#1) #199

merged 4 commits into from
Jan 6, 2021

Conversation

matthew-charles-chan
Copy link
Contributor

Summary

  • Name the plugin 'point-of-view' so it can be required as a plugin dependency.
  • Add instructions for requiring point-of-view as a plugin dependency in README.md.
  • Create test for name registration

mcollina
mcollina approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina reviewed Dec 21, 2020
View reviewed changes
index.js Outdated Show resolved Hide resolved
kibertoad
kibertoad reviewed Dec 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
Eomm
Eomm reviewed Dec 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@matthew-charles-chan
Update README for clarity
28c5c10 
add fastify.register to the example
add comma after "fastify-plugin"
@matthew-charles-chan matthew-charles-chan mentioned this pull request Dec 21, 2020
Merged
@matthew-charles-chan
Copy link
Contributor Author

@mcollina, Is it be possible to get this PR merged? It would be nice to be able to explicitly require this plugin as a dependency. Thanks!

@jsumners jsumners requested review from kibertoad and Eomm January 6, 2021 20:11
kibertoad
kibertoad approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@kibertoad kibertoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibertoad kibertoad merged commit eeb4c87 into fastify:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@lilpoozie2005 lilpoozie2005 lilpoozie2005 approved these changes

@kibertoad kibertoad kibertoad approved these changes

@Eomm Eomm Awaiting requested review from Eomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthew-charles-chan @mcollina @kibertoad @Eomm @lilpoozie2005